Match underscore in DLL to dash in identifier #3412
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
_
)These warnings are accurate; if you install one of these mods manually, CKAN will not recognize it. But we should be able to.
Changes
Now the code for finding manually installed mods (and the Netkan validation check for it) replaces underscores in DLL names with dashes. This will improve detection of such mods and clear some of these inflation errors.
Naturally, the CKAN client will not benefit from this until a new release includes this change, but the warnings will disappear from the status page right after merge, so for a while we will have some modules that are "missed" by this check. I think this is OK because this warning is pretty minor and not something we are actively trying to work on.