Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match underscore in DLL to dash in identifier #3412

Merged
merged 1 commit into from
Jul 11, 2021

Conversation

HebaruSan
Copy link
Member

Problem

  1. Open the status page
  2. In the filter field, type an underscore (_)
  3. Some of the warnings for "no plugin matching the identifier" are for cases where the DLL name has an underscore, which isn't allowed in an identifier anyway, and the corresponding identifier has a dash in the same place:
    NetKAN Warning
    KSP-PartVolume No plugin matching the identifier, manual installations won't be detected: GameData/KSP_PartVolume/Plugins/KSP_PartVolume.dll
    KerbalWeatherProject-Lite No plugin matching the identifier, manual installations won't be detected: GameData/KerbalWeatherProject_Lite/KerbalWeatherProject_Lite.dll
    NASA-CountDown No plugin matching the identifier, manual installations won't be detected: GameData/NASA_CountDown/Plugins/NASA_CountDown.dll

These warnings are accurate; if you install one of these mods manually, CKAN will not recognize it. But we should be able to.

Changes

Now the code for finding manually installed mods (and the Netkan validation check for it) replaces underscores in DLL names with dashes. This will improve detection of such mods and clear some of these inflation errors.

Naturally, the CKAN client will not benefit from this until a new release includes this change, but the warnings will disappear from the status page right after merge, so for a while we will have some modules that are "missed" by this check. I think this is OK because this warning is pretty minor and not something we are actively trying to work on.

@HebaruSan HebaruSan added Enhancement New features or functionality Easy This is easy to fix Core (ckan.dll) Issues affecting the core part of CKAN Pull request Netkan Issues affecting the netkan data labels Jul 11, 2021
@HebaruSan HebaruSan requested a review from DasSkelett July 11, 2021 17:04
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should make a handful of warnings disappear 👍

@HebaruSan HebaruSan merged commit bfb6323 into KSP-CKAN:master Jul 11, 2021
@HebaruSan HebaruSan deleted the fix/ad-underscore branch July 11, 2021 17:51
@HebaruSan
Copy link
Member Author

Should make a handful of warnings disappear

If the container restarts...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix Enhancement New features or functionality Netkan Issues affecting the netkan data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants