Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Russian localization #3443

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Update Russian localization #3443

merged 1 commit into from
Sep 6, 2021

Conversation

nt0g
Copy link
Contributor

@nt0g nt0g commented Sep 3, 2021

A question I have: are empty strings allowed?

Asking specifically for the "ModSearchYesPrefix" string. Russian doesn't use copulas in the way English does, which means (besides the obvious) I can't find a translation that will also agree with mod state adjectives.

@HebaruSan
Copy link
Member

Thanks for the updates! No, an empty string won't work for that one. We need to be able to check whether a search string begins with it:

CKAN/GUI/Model/ModSearch.cs

Lines 317 to 343 in 2a2b12e

else if (TryPrefix(s, Properties.Resources.ModSearchYesPrefix, out string yesSuffix))
{
if (yesSuffix == Properties.Resources.ModSearchCompatibleSuffix)
{
compatible = true;
}
else if (yesSuffix == Properties.Resources.ModSearchInstalledSuffix)
{
installed = true;
}
else if (yesSuffix == Properties.Resources.ModSearchCachedSuffix)
{
cached = true;
}
else if (yesSuffix == Properties.Resources.ModSearchNewlyCompatibleSuffix)
{
newlyCompatible = true;
}
else if (yesSuffix == Properties.Resources.ModSearchUpgradeableSuffix)
{
upgradeable = true;
}
else if (yesSuffix == Properties.Resources.ModSearchReplaceableSuffix)
{
replaceable = true;
}
}

@nt0g
Copy link
Contributor Author

nt0g commented Sep 3, 2021

I understand. The translations I used should work for most use cases.

Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no way to assess the quality of Russian text, but since you contributed the originals, we have every reason to trust you.

Thanks for the update!

@HebaruSan HebaruSan merged commit c087675 into KSP-CKAN:master Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants