-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show context menu on menu key press #3446
Conversation
68fc370
to
ef4ee26
Compare
65b70ce
to
8a10141
Compare
For some reason this isn't working for me, neither in the GUI nor the console UI, not when started through my IDE nor otherwise.
In other applications like Firefox or Dolphin or other KDE windows it works fine. I blame some misconfiguration of my system or KDE not handling it correctly. |
Hmm, I'm seeing the same thing now in GNOME Shell, including the same null values for
I developed this in Windows, too. I'm guessing Mono has a problem handling this key. |
Confirmed Mono bug (or something more complicated); this function receives keycode 135 and returns 0: The
... but then the |
Problem
Most keyboards have a key to open a context menu (mine requires pressing Fn+PrintScrn, but it's there). Currently this does nothing in CKAN, to the detriment of keyboard users.
Cause
The mod list context menu is implemented in the grid's
MouseDown
event, and pressing the menu key triggersKeyDown
and does nothing.Changes
Now the code to manage the menu is moved a new
ShowModContextMenu
function, which is called fromMouseDown
on a right click andKeyDown
forKeys.Apps
(the code for the menu key).Similar changes are also made for the URL link labels in mod info and the About dialog, as well as the list of instances in the manage game instances dialog. And this key also now opens and closes the F10 menu in ConsoleUI.
Fixes #3445.