Append resource links to staging PRs #3454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This staging reason explicitly mentions "the forum thread" but fails to provide it:
KSP-CKAN/CKAN-meta#2460
That makes these PRs somewhat annoying to review, since you have to find that link yourself (probably via the status page or by checking the metadata).
Changes
Now we append a table of the mod's
resources
links to the body of any staging pull request:KSP-CKAN/CKAN-meta#2462 (manually inserted)
Behind the scenes:
StagingTransformer
has to run before the$kref
processors to be able to detect hard coded versions, but we usually only have the resources available after those transformers run<link>
syntax for links because otherwise GitHub excludes a trailing*
from the URL, which we use to abbreviate a lot of forum URLs--debug
prints the Markdown source of the table in case you want to see it