Enforce spec version requirements for more install properties #3494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The spec says:
https://github.com/KSP-CKAN/CKAN/blob/master/Spec.md#install
The version numbers in parentheses are supposed to be the minimum
spec_version
required to use the given property.Problem
Currently you can use these properties with any
spec_version
and Netkan will not complain. This means that a client supporting an old spec version might be presented with metadata that it can't handle (but this is very unlikely to ever be a real problem because there is really only the one client, and versions of it that old won't even run anymore thanks to TLS changes on GitHub).Changes
Now Netkan's
InstallValidator
enforces these requirements.