Improve translation process #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olympic1
added
Enhancement
HebaruSan
reviewed
Aug 29, 2022
| ignore: | ||
| - Properties/ | ||
| - Localization/ | ||
| - HintTextBox.resx |
There was a problem hiding this comment.
Is HintTextBox.resx excluded because it doesn't have any text resources? Or is there something else special about it?
There was a problem hiding this comment.
Sorry for the late answer, was a busy week(end).
I exluded it because Crowdin just copied the file for each translation because everything was supposedly translated when there is just nothing to translate.
HebaruSan
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
Well whatever the reason for ignoring HintTextBox.resx, it's working fine and we can make more updates later if appropriate. Let's merge.
(I'm thinking along the lines of deleting HintTextBox.resx completely, or at least removing its $this.TrayLargeIcon property, which looks unnecessary and weird.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current translation process is difficult for users who that don't know or can't work with Git. The users that can, can sometimes forget some translations.
This will improve that process for those users as they just have to create an account on Crowdin and can start translating with very easy steps. Every translatable string is shown for them so none is forgotten.
Changes
Added a configuration file to upload the translatable files to Crowdin.