Red highlight for dependencies on missing DLC #3698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If a mod depends on a DLC that you don't have installed, the mod will be treated as incompatible with a red stop sign on the relationships tab due to the missing dependency (since CKAN can't install DLC even if there's a version of it that's compatible with your game version). But if you look at the relationships tab of mod info to try to figure out why it's incompatible, there's no indication that this is the reason:
Changes
Now if a mod depends on a DLC that isn't installed, the relationship will be highlighted red, just like for an incompatible dependency: