Remote swinfo files, sw vref warnings #3817
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
version_check
URL property that works just like the version fileURL
property, but so far we don't support itswinfo.json
file but its netkan has no$vref
, there's no warning$vref: '#/ckan/space-warp'
but the mod contains noswinfo.json
file, there's no warningChanges
swinfo.json
containsversion_check
, we parse it as a URL, retrieve the designated page, and parse it as JSON. If this works and the local and remoteversion
properties match, we use the remote file instead of the local file.resources.remote-swinfo
is set to this URLckan show
and GUI display itswinfo.json
file but its netkan has no$vref
, netkan prints a warning$vref: '#/ckan/space-warp'
but the mod contains noswinfo.json
file, netkan prints a warningWill self-review because this won't affect users until the full KSP2 stack is live.