Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote swinfo files, sw vref warnings #3817

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

HebaruSan
Copy link
Member

Motivations

  • The SpaceWarp team has implemented a version_check URL property that works just like the version file URL property, but so far we don't support it
  • If a mod has a swinfo.json file but its netkan has no $vref, there's no warning
  • If a netkan has $vref: '#/ckan/space-warp' but the mod contains no swinfo.json file, there's no warning

Changes

  • Now if swinfo.json contains version_check, we parse it as a URL, retrieve the designated page, and parse it as JSON. If this works and the local and remote version properties match, we use the remote file instead of the local file.
    • resources.remote-swinfo is set to this URL
    • ckan show and GUI display it
  • Now if a mod has a swinfo.json file but its netkan has no $vref, netkan prints a warning
  • Now if a netkan has $vref: '#/ckan/space-warp' but the mod contains no swinfo.json file, netkan prints a warning

Will self-review because this won't affect users until the full KSP2 stack is live.

@HebaruSan HebaruSan added Bug Something is not working as intended Enhancement New features or functionality Easy This is easy to fix GUI Issues affecting the interactive GUI Cmdline Issues affecting the command line Core (ckan.dll) Issues affecting the core part of CKAN Spec Issues affecting the spec Netkan Issues affecting the netkan data Schema Issues affecting the schema labels Mar 26, 2023
@HebaruSan HebaruSan merged commit 8146db1 into KSP-CKAN:master Mar 26, 2023
@HebaruSan HebaruSan deleted the feature/remote-swinfo branch March 26, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Cmdline Issues affecting the command line Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix Enhancement New features or functionality GUI Issues affecting the interactive GUI Netkan Issues affecting the netkan data Schema Issues affecting the schema Spec Issues affecting the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant