Hide fake instance creation in GUI #3839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users somewhat frequently ask why they get an error when they try to launch the game for a fake instance (see #2665):
Cause
These are created via the "Fake new KSP instance" option:
I think we added this on the general principle that features should be available in CmdLine, ConsoleUI, and GUI when possible. But creating a non-functional game folder is not something that normal users need to do, and its availability causes confusion. Some seem to assume they can make it install an arbitrary game version, without considering why the option they're clicking on says "fake".
Changes
Now instance faking is removed from GUI. The dropdown in Manage Game Instances now says "Clone instance" (translation updates attempted) and is disabled if no instance is selected in the grid:
Once you select an instance, it's enabled:
If you click it, the dialog appears, with all of the UI elements associated with "fake" removed:
The instance in the dropdown will match the row you selected in Manage Game Instances but can still be changed.
This should more firmly guide users towards cloning (which is useful to them) and away from faking (which is not). It also conveniently sidesteps the need to create faking functionality for KSP2 in GUI (which doesn't have KSP1's DLCs, meaning a more complex UI would be needed). The
ckan instance fake
command is still available for expert users and CI/CD, and has not been changed.