Show download errors for upgrades #3840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If an upgrade's download fails, the failed downloads popup from #3635 appears, but empty:
This dead-ends any investigation of such problems.
Originally reported by forum user jost.
Cause
The rows of that table are built based on the mods in the changeset, but only the mods to install were included. The mods to upgrade were not, so if one of them had an error, it wouldn't be shown.
Changes
Now the mods we're upgrading are also passed to the form, so the error appears as expected:
While investigating this, I found that the popup could cause CKAN to freeze before it opened, and that passing itself to
Util.Invokeinstead of a reference to theMainform fixed it, so that's included here as well.