Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation updates from Crowdin #3866

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Jul 22, 2023

This is like #3835 without conflicts, which I suspect were caused by Crowdin lacking many recent changes from the master branch (notified @Olympic1 about this on Discord in hopes of having it fixed). I used the bin/git-xml-diff.sh tool to find and remove bad changes (conflicts and attempted reversions of changes that should not be reverted) while igoring format-only changes.

Also some recent translations were not being repacked into the auto updater, and this is now fixed.

@HebaruSan HebaruSan added GUI Issues affecting the interactive GUI Cmdline Issues affecting the command line Core (ckan.dll) Issues affecting the core part of CKAN AutoUpdate Issues affecting the automatic updating ConsoleUI Issues affecting the interactive console UI i18n Issues regarding the internationalization of CKAN and PRs that need translating labels Jul 22, 2023
@HebaruSan
Copy link
Member Author

HebaruSan commented Jul 22, 2023

Crowdin lacking many recent changes from the master branch (notified @Olympic1 about this on Discord in hopes of having it fixed)

A clue!

image

image

image

I can't find a way to see what the issues are, though. It might be hidden someplace I can't access.

image

@HebaruSan
Copy link
Member Author

Interestingly, the GitHub side of the webhook shows no problems at all, just green checkmarks all the way down.

@HebaruSan

This comment was marked as resolved.

@HebaruSan HebaruSan merged commit a8e3ce3 into KSP-CKAN:master Jul 23, 2023
@HebaruSan HebaruSan deleted the fix/i18n-updates branch July 23, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoUpdate Issues affecting the automatic updating Cmdline Issues affecting the command line ConsoleUI Issues affecting the interactive console UI Core (ckan.dll) Issues affecting the core part of CKAN GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant