Fix Netkan swinfo transformer null list error #3869
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
KSP-CKAN/KSP2-NetKAN#75
Cause
If a module has no
depends
relationships, thenmod.depends
is null here, and.Select
doesn't work:CKAN/Netkan/Transformers/SpaceWarpInfoTransformer.cs
Lines 87 to 89 in 83b6e7d
This problem was masked by all previous mods with
swinfo.json
files having a dependency on SpaceWarp.Changes
Now if
CkanModule.depends
is null, we substitute the empty sequence.Will self-review so that pull request can proceed.