Fix archive.org fallback URLs for versions with spaces #3899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
CkanModule
s with nulldownload
properties, and after switching back out of that branch, trying to install such a module threw a null reference exceptionChanges
Ckan.InternetArchiveDownload
replaces spaces with underscores, so the client will be able to find the fallback downloads of affected modulesGetInProgressFileName
calls are more careful to avoid null referencesI think I'll self-review this since it's so minor.