Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix archive.org fallback URLs for versions with spaces #3899

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

HebaruSan
Copy link
Member

Problems

  • Spaces aren't allowed in archive.org bucket names, and recently a few mods have put spaces in their version strings, which broke the Mirrorer. To fix that, that Don't allow spaces in filenames for archive.org NetKAN-Infra#307 replaced those spaces with underscores. This allowed the mod to be mirrored, but the client doesn't perform the same substitution yet.
  • In another branch, I have some code that generates CkanModules with null download properties, and after switching back out of that branch, trying to install such a module threw a null reference exception

Changes

  • Now Ckan.InternetArchiveDownload replaces spaces with underscores, so the client will be able to find the fallback downloads of affected modules
  • Now the GetInProgressFileName calls are more careful to avoid null references

I think I'll self-review this since it's so minor.

@HebaruSan HebaruSan added Bug Something is not working as intended Easy This is easy to fix Core (ckan.dll) Issues affecting the core part of CKAN Network Issues affecting internet connections of CKAN labels Sep 1, 2023
@HebaruSan HebaruSan merged commit 3ef0a29 into KSP-CKAN:master Sep 1, 2023
10 checks passed
@HebaruSan HebaruSan deleted the fix/archive-urls branch September 1, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix Network Issues affecting internet connections of CKAN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant