Better handling for DLC with missing readme.txt #3935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Easy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
@JonnyOThan reported the following error with the current dev build:
Cause
The DLC's folder was present, but its
readme.txtfile was absent. This caused itsCkanModule.versionproperty to be missing, which isn't allowed.Originally this would have defaulted to
new UnmanagedModuleVersion(null), but this was lost in #3904's refactoring.Changes
Now we once again default to
new UnmanagedModuleVersion(null), as per previous releases. A new test exercises this case to make sureRegistry.SetDLCsdoesn't start throwing again.I'll probably self-review this since it's small and a regression.