Prompt to delete dirs containing empty registered dirs #3942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This (or the previous step, not clear) should create a
GameData/TweakScale/Plugins/PluginData/Scale/config.xml
file(Don't ask me why this isn't just
GameData/TweakScale/PluginData/config.xml
instead.)PluginData
folder, but not thePlugins
orTweakscale
parent foldersCause
I think #3890's changes to the the deletion logic must have affected how subdirectories are treated, but I was more focused on understanding and fixing the current logic than on the details of the history.
Changes
Now when we check whether to ask the user about deleting a directory, we ignore any subdirectories that are already in that list. This will add the
GameData/TweakScale
andGameData/TweakScale/Plugins
folders to the list, and clicking Delete Checked will result in a clean GameData:Fixes #3936.