Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict highlight for selected row #3951

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

HebaruSan
Copy link
Member

Problems / Motivations

  • If you select to install two mods that conflict, their background color properties are set to a reddish color, but this is completely overridden by the blue row highlight color. If the other conflicting mod's row is off-screen, this usually meant that you couldn't see any red highlights at all.
  • Conflict descriptions are missing from the status bar in some cases
  • If you apply multiple labels to a mod, only one of their background colors is applied

Causes

  • RelationshipResolver.ConflictDescriptions only returned descriptions of conflicts for the mod with fewer indirectly-depending mods, intended to choose the conflict closest to what the user selected, but when these values were equal, neither would appear.

Changes

  • Now if two conflicting mods have equal numbers of indirectly-depending mods, both of their description conflicts are shown in the status bar
  • Now if you select a row with a conflict, the red color is blended 75%/25% with the highlight color, producing a reddish purple color that can still be recognized as conflict-y:
    image
    The red conflict color has had its green and blue channels roughly halved to make this work a bit better.
  • Similar to the above, a background color from a label is also blended 75%/25% with the highlight color so you can still tell a label has been applied while the row is highlighted
  • Now if you apply multiple labels, their colors are blended together, and the labels menu shows the colors of the labels:
    image

Fixes #3947.

@HebaruSan HebaruSan added Bug Something is not working as intended Enhancement New features or functionality GUI Issues affecting the interactive GUI labels Dec 14, 2023
@HebaruSan HebaruSan requested a review from techman83 December 14, 2023 18:41
@HebaruSan
Copy link
Member Author

Self-reviewing so we can include this in the hotfix release...

@HebaruSan HebaruSan merged commit 7bc8aec into KSP-CKAN:master Dec 14, 2023
8 checks passed
@HebaruSan HebaruSan deleted the feature/gui-conflict-highlight branch December 14, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Enhancement New features or functionality GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SelectionBackColor of conflict rows should be a different color (dark red?)
1 participant