Generate schema compliant game versions from swinfo.json #3969
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cause
The schema supports 0.2.0 but not 0.2.0.0.
CKAN/CKAN.schema
Lines 380 to 384 in 3e8950a
The
SpacedockTransformer
usesGameVersion.WithoutBuild
to remove the 4th piece from the game version the user selects on SpaceDock:CKAN/Netkan/Transformers/SpacedockTransformer.cs
Line 79 in 3e8950a
But the
SpaceWarpInfoTransformer
does not do the same for the game versions inswinfo.json
:CKAN/Netkan/Transformers/SpaceWarpInfoTransformer.cs
Lines 78 to 84 in 3e8950a
Changes
Now game versions from
swinfo.json
are trimmed to conform to the schema.