Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress admin user check for URL handler registration #3996

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

HebaruSan
Copy link
Member

Problem

In a recent forum thread, a user reported receiving the URL handler registration prompt:

CKAN requires permission to add a handler for ckan:// URLs.

Do you want to allow CKAN to do this? If you click no you won't see this message again.

And after clicking Yes, the admin user error appeared in a new cmd window, while the main GUI process continued normally.

Cause

The URL handler registration intentionally runs ckan.exe gui registerUrl as administrator, which trips the admin user check.

Changes

Now the elevated command line to register the handler includes --asroot to bypass the admin check. This should allow it to finish normally.

@HebaruSan HebaruSan added Bug Something is not working as intended Easy This is easy to fix GUI Issues affecting the interactive GUI Windows Issues specific for Windows labels Jan 10, 2024
@HebaruSan HebaruSan merged commit 62a0bc7 into KSP-CKAN:master Jan 10, 2024
8 checks passed
@HebaruSan HebaruSan deleted the fix/url-handler-asroot branch January 10, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Easy This is easy to fix GUI Issues affecting the interactive GUI Windows Issues specific for Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant