Fix crash with DLC disabled by Steam #4002
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you disable a DLC in Steam:
... then CKAN throws an exception when it tries to refresh:
Cause
Steam apparently deletes the files for that DLC but leaves behind all the folders:
This eventually makes our
DictionaryEquals
extension try to callnull.Equals()
:Changes
DictionaryEquals
extension usesEqualityComparer<V>.Default.Equals
for better null handlingfalse
if the readme file doesn't exist, so DLCs disabled by Steam will be considered not installedFixes #4000.