Fix exception on clicking Play before dropdown appears #4028
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cause
Main.LaunchGame
implicitly assumes its string argument will not be null.ManageMods.LaunchGameToolStripMenuItem_Click
passesmenuItem?.Tag as string
, which implicitly assumes the menu item'sTag
will always be set.The tag is set in
LaunchGameToolStripMenuItem_MouseHover
, which is executed when you hover the button, but after a short delay. If you click before the delay is over, the tag is null.Changes
Now
Main.LaunchGame
allows a null argument and defaults to the first configured command line.