Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fully sanitized archive.org bucket names #4043

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

HebaruSan
Copy link
Member

Motivation

archive.org only allows certain characters in an upload's "bucket name", and KSP-CKAN/NetKAN-Infra#328 updated NetKAN-Infra to remove illegal characters (other than colon and space, which are already handled specially) before uploading so we could get a mod with & in its version string out of the bot's queues.

Changes

  • CkanModule.InternetArchiveDownload now removes the same characters as in the above PR, so it will find the correct URL for affected mods
  • The redistributable license check in NetKAN-Infra (correctly) treats a mod with multiple licenses as redistributable if any of those licenses is redistributable, but the client required all licenses to be redistributable. Now the client is updated to use "any" logic instead.

@HebaruSan HebaruSan added Enhancement New features or functionality Easy This is easy to fix Core (ckan.dll) Issues affecting the core part of CKAN Network Issues affecting internet connections of CKAN labels Feb 28, 2024
@HebaruSan HebaruSan merged commit 726adac into KSP-CKAN:master Feb 28, 2024
8 checks passed
@HebaruSan HebaruSan deleted the fix/bucket-names branch February 28, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix Enhancement New features or functionality Network Issues affecting internet connections of CKAN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant