Use fully sanitized archive.org bucket names #4043
Merged
+28
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
archive.org only allows certain characters in an upload's "bucket name", and KSP-CKAN/NetKAN-Infra#328 updated NetKAN-Infra to remove illegal characters (other than colon and space, which are already handled specially) before uploading so we could get a mod with
&
in its version string out of the bot's queues.Changes
CkanModule.InternetArchiveDownload
now removes the same characters as in the above PR, so it will find the correct URL for affected mods