Fix NRE on trying to update all when there's nothing to update #4054
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
(The above steps are just one specific way that I've found to get to this point. It may or may not be how other users might get here, but the below problem happens regardless of the specific path taken.)
Cause
ManageMods.mainModList.full_list_of_mod_rows
is null when the grid is empty, andManageMods.MarkAllUpdates
accesses its.Values
property.Changes
ManageMods.mainModList.full_list_of_mod_rows
is set to an empty dictionary on initialization, so it can always be accessed safely, and clicking the button with an empty list will do nothing.foreach
loop inManageMods.ChangeSetUpdated
now uses a deconstructor to get the key and value separately instead of akvp
variable to represent the key value pair. This isn't needed to fix anything, but it's nice for readability.Fixes #4053.