ConsoleUI prompt to delete non-empty folders after uninstall #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Enhancement
HebaruSan
force-pushed
the
feature/consoleui-del-dirs
branch
from
5eb8740 to
57162fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#2962 added a prompt in GUI to ask the user whether to delete folders that contain only files not created by CKAN after uninstalling a mod, because such folders can make ModuleManager
:NEEDS[]clauses behave as if a mod is installed when it's not.Currently this isn't available in ConsoleUI, even though the concern about leftover folders and ModuleManager still applies.
Changes
Now ConsoleUI presents a screen after uninstallation to ask about these directories as well, if any are found:
(The
GameData/SquadandGameData/SquadExpansionfolders would never be included here in practice. I was just using them for testing.)Fixes #3484.