Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A Discord user reported an exception at startup:
Cause
A code audit suggests that this exception could be thrown if
Repository.url
is null, which is not supposed to be possible but could happen ifregistry.json
has the repo URL set to the empty string. (The deserializer throws an exception instead if it'snull
in the file, so we can rule that out.)However, when I tried this, I got many other exceptions in other earlier spots in the code that access this property. At time of writing we have asked follow-up questions for further investigation but haven't heard back yet. The same user said they saw an earlier error message relating to
GUIConfig.xml
(we don't know which one), so it's possible they're experiencing some disk corruption.Changes
Repository.url
are updated to handle null values better.default
was being added. Now it's changed to<Game shortname>-<localized equivalent of "default">
, consistent with the repo we initially add when you add the instance.