Store GitHub Discussions links and display in UIs #4111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The KSP franchise's future status has become a bit uncertain, and the forum web site has been somewhat unreliable lately.
If the forums became unavailable, GitHub Discussions would be one possible alternate place where particular mods might be discusssed.
Changes
resources.discussions
to be a URL(But no
spec_version
limitations are imposed because it's easy for the old client to just ignore the new value)resources.discussions
to that repo's discussions URL, just like we do forresources.bugtracker
resources.discussions
link in their respective mod info displaysThis way if mod authors start enabling discussion for their repos, either now or upon the sudden disappearance of the forum, the URLs will begin appearing in CKAN so users can find out about them.
Considered but not done
The obvious question here is: What about
resources.homepage
, which for most mods will be set to a forum thread? It would be amazing to automatically retire those links and switchresources.homepage
over to discussions automatically, but after some consideration, I don't think that's a viable option:For these reasons, the discussions link is added separately and homepage is left alone.