Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store GitHub Discussions links and display in UIs #4111

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Jun 26, 2024

Motivation

The KSP franchise's future status has become a bit uncertain, and the forum web site has been somewhat unreliable lately.

If the forums became unavailable, GitHub Discussions would be one possible alternate place where particular mods might be discusssed.

image

Changes

  • Now the spec and schema allow resources.discussions to be a URL
    (But no spec_version limitations are imposed because it's easy for the old client to just ignore the new value)
  • Now Netkan checks whether discussions are enabled for GitHub repos, and if so, it sets resources.discussions to that repo's discussions URL, just like we do for resources.bugtracker
  • Now CmdLine, ConsoleUI, and GUI include the resources.discussions link in their respective mod info displays

This way if mod authors start enabling discussion for their repos, either now or upon the sudden disappearance of the forum, the URLs will begin appearing in CKAN so users can find out about them.

Considered but not done

The obvious question here is: What about resources.homepage, which for most mods will be set to a forum thread? It would be amazing to automatically retire those links and switch resources.homepage over to discussions automatically, but after some consideration, I don't think that's a viable option:

  • The forum is not yet dead, and Netkan won't know programmatically if that happens
  • Some other forum preservation option may become available for migrating homepages, such as via the Internet Archive
  • Some authors may prefer to keep the old links available for nostalgic purposes
  • Some authors may want to use both a hompage and a discussions link (for example, when the homepage is non-interactive like a wiki)

For these reasons, the discussions link is added separately and homepage is left alone.

@HebaruSan HebaruSan added Enhancement New features or functionality Easy This is easy to fix GUI Issues affecting the interactive GUI Cmdline Issues affecting the command line Core (ckan.dll) Issues affecting the core part of CKAN Spec Issues affecting the spec Netkan Issues affecting the netkan data Schema Issues affecting the schema ConsoleUI Issues affecting the interactive console UI labels Jun 26, 2024
@HebaruSan HebaruSan merged commit 24fbd16 into KSP-CKAN:master Jun 26, 2024
3 checks passed
@HebaruSan HebaruSan deleted the feature/github-discussions branch June 26, 2024 20:06
@HebaruSan
Copy link
Member Author

Huh, a surprising number of mod repos are already using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cmdline Issues affecting the command line ConsoleUI Issues affecting the interactive console UI Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix Enhancement New features or functionality GUI Issues affecting the interactive GUI Netkan Issues affecting the netkan data Schema Issues affecting the schema Spec Issues affecting the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant