Update changeset on Replace checkbox change, other replaced_by fixes #4128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
After #4127 and KSP-CKAN/CKAN-meta#3277, further testing found more issues with
replaced_by
:Causes
ManageMods.ModGrid_CellValueChanged
doesn't react to checkbox changes when the column isReplaceCol
SelectionReason.Replacement
was not actually in use anywhereChanges
ManageMods.ModGrid_CellValueChanged
updates the changeset when a checkbox changes in theReplaceCol
column, so the apply button becomes enabled when it shouldReplacing <list of mods it replaces>
This should further move
replaced_by
towards becoming working, useful functionality. It still needs some massaging and refactoring, but now you can actually use it to replace mods.Note that if you test this with the Nehemiah stuff (somewhat helpful), there are conflicts between some of the old mods and the new one, so you may have to replace them all to be able to continue.