Handle multiple download URLs per module #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Enhancement
HebaruSan
force-pushed
the
feature/download-list
branch
3 times, most recently
from
9e54d4b to
323c842
Compare
|
I don't know what's wrong with the Coverage check, but it doesn't look like it's related to these changes. I meant to push 75acc13 to this branch but accidentally put it on master instead. 😳 |
HebaruSan
force-pushed
the
feature/download-list
branch
2 times, most recently
from
4f58f18 to
0e76896
Compare
techman83
requested changes
Aug 10, 2023
There was a problem hiding this comment.
Really only some minor feedback, looks like the coverage action is currently a bit busted. It is actually reporting the coverage, but maybe GitHub have changed something in terms of scoping the permissions.
If you'd like I can add some branch protection rules? We can still override them when required, but gives the ability to avoid accidentally pushing
techman83
approved these changes
Aug 11, 2023
|
We can fix the coverage separately, it's failing for issues unrelated to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As of KSP-CKAN/CKAN#3877 and the next release of the CKAN client, it will be possible for the
downloadproperty to contain a list of multiple URLs. A few places in the Infra assume it will be a single value.Changes
Ckan.downloadproperty is updated to preserve backwards compatibility by always returning the first URL if there are multiple. This will ensure that all old code using this property will continue to work as previously. For example, theMirrorerdoesn't really need to check multiple URLs to do its job, so it will continue using this property.Ckan.downloadsproperty is added that always returns a list, which includes the archive.org fallback URLs for modules that have them. TheDownloadCounteris updated to use this property to count and sum all of the downloads for modules that have multiple URLs.