Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KWRocketry-CommunityFixes and interstage #2000

Merged
merged 1 commit into from
Jul 29, 2015

Conversation

mheguy
Copy link
Contributor

@mheguy mheguy commented Jul 28, 2015

And add conflict to netkan of KWRocketry (Community fixes are to be applied to non-netkan version of KWRocketry).

@dbent would love a second set of eyes on this.

Thanks to @TeddyDD whose metadata I basically copy + pasted.
Related issue: KSP-CKAN/CKAN-meta#724

This adds netkans for CommunityFixes and interstage in case they need updates. This also adds a conflict to KWRocketry so that any version other than 2.7.0-community (which isn't netkan-generated) will have a conflict to the fixes.

…of KWRocketry (Community fixes are to be applied to non-netkan version of KWRocketry)
@TeddyDD
Copy link
Contributor

TeddyDD commented Jul 28, 2015

This adds netkans for CommunityFixes and interstage in case they need updates. This also adds a conflict to KWRocketry so that any version other than 2.7.0-community (which isn't netkan-generated) will have a conflict to the fixes.

Wow I didn't know about this behaviour :O It seems I should learn C# and at least read code of this thing :)

@mheguy
Copy link
Contributor Author

mheguy commented Jul 28, 2015

Basically netkan gets all its information from $kref (in this case KW's KerbalStuff page). 2.7.0-community isn't included in KW's KerbalStuff release list so it's outside of netkan's "sphere of influence". By adding the conflicts relationship to the netkan it will affect only official KW releases, giving us the behaviour we want (CommunityFixes only being compatible with the community version of KW).

@dbent
Copy link
Member

dbent commented Jul 28, 2015

So this is basically so that we say "KWRocektry works with KSP 1.0.4 if this other mod is installed"? Looks fine to me then.

Expressing something like this may be useful in a theoretical condition property in relationships.

@mheguy
Copy link
Contributor Author

mheguy commented Jul 29, 2015

I'm always in favour of an expanded toolset. 😄
Thanks for having a look.

mheguy pushed a commit that referenced this pull request Jul 29, 2015
Add KWRocketry-CommunityFixes and interstage to match up with community version of KW, add conflict between official releases and community fixes
@mheguy mheguy merged commit 222d80f into KSP-CKAN:master Jul 29, 2015
@mheguy mheguy deleted the kwrocketry branch July 29, 2015 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants