Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN update rss textures version #6694

Merged
merged 2 commits into from
Aug 28, 2018
Merged

RN update rss textures version #6694

merged 2 commits into from
Aug 28, 2018

Conversation

raidernick
Copy link
Contributor

-update version to support ksp 1.4.x

@HebaruSan
Copy link
Member

Thanks for the updates! Merging...

@HebaruSan HebaruSan merged commit 4de9588 into KSP-CKAN:master Aug 28, 2018
@raidernick
Copy link
Contributor Author

@HebaruSan is this some sort of new change to how versioning works where you don't need to come up with some large version number to cover all potential game versions? Does it need to be done in the .version files included with the mods themselves also that don't set the version number in the actual netkan file?

@HebaruSan
Copy link
Member

HebaruSan commented Aug 28, 2018

It's not new; the code that translates "1.4" into [1.4.0, 1.5.0) is at least 2 years old (see KSP-CKAN/CKAN#1645):

https://github.com/HebaruSan/CKAN/blob/547976009d479b0ca5a24e51375eaa186866cd52/Core/Versioning/KspVersion.cs#L261-L265

As for .version files, I would defer to the author and/or maintainer of KSP-AVC, as the spec doesn't say whether the PATCH property is required. But in general, CKAN's ksp_version properties are related to but not exactly the same as KSP-AVC's KSP_VERSION properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants