Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water Launch Sites - recommend MakingHistory-DLC #7205

Merged
merged 1 commit into from
May 28, 2019

Conversation

yalov
Copy link
Contributor

@yalov yalov commented May 25, 2019

---
Edited by @DasSkelett:
See KSP-CKAN/CKAN#2326
---

@DasSkelett
Copy link
Member

DasSkelett commented May 25, 2019

This will need some changes in the client before it works.
Current output if I try to install it via commandline:

4246 [1] INFO CKAN.RelationshipResolver (null) - MakingHistory-DLC is recommended/suggested but it is not listed in the index,
or not available for your version of KSP.

The GUI just skips the recommendation screen.
Can't test the consoleUI, it has no "Install from .ckan" functionality I think.

@yalov
Copy link
Contributor Author

yalov commented May 25, 2019

it's ok, you can't buy it via CKAN. It is suppose to be informational

@DasSkelett
Copy link
Member

DasSkelett commented May 25, 2019

Right now you can only see it in the relationships tab in the lower right corner. If that's enough for you, we don't need to change anything.
If you want it to show up in the recommendation tab, as a simple text entry or something, it would need some work.

@yalov
Copy link
Contributor Author

yalov commented May 25, 2019

[edited]
the relationships tab is ok for this PR,
but for celebrating new DLC, something as text in the recommendation and suggestion tab could be helpful

@HebaruSan
Copy link
Member

Looks OK (with the already noted caveat that it won't do anything), merging...

@HebaruSan HebaruSan merged commit bf518bd into KSP-CKAN:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants