Fix install_to capitalization of Scatterer config and sunflare #8862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest Scatterer update (0.0825b) changed the capitalization of the directory name in GameData from
scatterertoScatterer.This seems to cause some issues within CKAN, especially on systems with case-insensitive filesystems (-> Windows).
The
install_tostanza of the config and sunflare modules still install it with a the lower-case directory name.On Linux, this creates to separate directories, on Windows the one that gets installed first wins.
There might still be code fixes needed in the client, but at least the metadata is correct now.
Note that while the
findproperties where still lowercase too, the relevant parts within netkan and the client did match those case-insensitive, that's why we didn't get "No file found to install errors" after the update.