Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword many fields, add explanations, move fields into different sections. #5

Merged
merged 5 commits into from
May 22, 2016

Conversation

mheguy
Copy link
Contributor

@mheguy mheguy commented May 20, 2016

A lousy title and commit message, this is just a bunch of cosmetic changes. Some things reworded to use CKAN nomenclature (like relationships). Many fields have increased explanation of what's expected. "KSP_version" moved up into "mandatory" (KSP-CKAN/CKAN#1742 for more). Strict version matching moved into "advanced". And much more.

Closes #9

<div id="install_fields">
<ol>
<ol> If this mod requires other mods to be installed alongside it, use Relationships.<b>Do not use install instructions to install multiple mods.</b>
Copy link
Contributor Author

@mheguy mheguy May 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line in particular probably needs an edit since I imagine this text should be inside some kind of element.

@janbrohl
Copy link
Collaborator

edited to #9

# Conflicts:
#	static/index.html
@@ -147,42 +147,48 @@
</li>
<li>
<label>KSP-Version<br /><input type="text" id="ksp_version" size="40" /></label> examples: <code>==1.0</code> or <code>&lt;=1.1&gt;=1.0.3</code>
<br />
<small>While not technically mandatory, not providing this field is considered bad practice.</small>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that if/when KSP-CKAN/CKAN#1742 is merged this will be technically mandatory.

@janbrohl janbrohl merged commit aa83bc9 into master May 22, 2016
@mheguy mheguy deleted the rewording branch May 22, 2016 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants