Update 'ckan ksp fake' syntax for dummy instances #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
reviewed
Jun 9, 2019
DasSkelett
force-pushed
the
fix/dummy-ksp-dlcs
branch
from
d595c27
to
be1aac8
Compare
HebaruSan
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for KSP-CKAN/CKAN#2773.
Wait with merge until 2773 is merged too.
2773 changes the syntax of
ckan ksp faketo a more future proof one (hopefully...).Also it CKAN will throw an error if a faked DLC is requested but the KSP version is too low.
The fact that there was now error thrown was used by the scripts, but it won't work anymore. So a version comparison is needed to decide whether to fake a DLC or not.