Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE:TAG should be set/get. Right now it's just get-only. #2469

Closed
Dunbaratu opened this issue Mar 21, 2019 · 0 comments · Fixed by #2472
Closed

CORE:TAG should be set/get. Right now it's just get-only. #2469

Dunbaratu opened this issue Mar 21, 2019 · 0 comments · Fixed by #2472
Labels
enhancement Something new (not a bug fix) is being requested

Comments

@Dunbaratu
Copy link
Member

If you do set core:tag to "name". it complains that that's not allowed. It's because that's not a SetSuffix and is read-only. However if you do set core:part:tag to "name". it works just fine.

The problem is that the partmodule wrapper kOSProcessorFields defines its "TAG" like so, as a read-only:

 AddSuffix("TAG", new NoArgsSuffix<StringValue>(() => processor.Tag, "This processor's tag"));

There's no reason it couldn't be settable too.

@Dunbaratu Dunbaratu added the enhancement Something new (not a bug fix) is being requested label Mar 21, 2019
Dunbaratu added a commit to Dunbaratu/KOS-1 that referenced this issue Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something new (not a bug fix) is being requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant