Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stage:liquidfuel wrong when using radial decouplers #981

Closed
gregbean opened this issue May 8, 2015 · 6 comments
Closed

stage:liquidfuel wrong when using radial decouplers #981

gregbean opened this issue May 8, 2015 · 6 comments
Labels
bug Weird outcome is probably not what the mod programmer expected.

Comments

@gregbean
Copy link

gregbean commented May 8, 2015

stage:liquidfuel shows the correct value when using a stack decoupler, but includes the fuel for the next stage when using radial decouplers. See the attached images for two very similar rockets. The top rocket uses a stack decoupler and stage:liquidfuel is correct, the bottom has radial decouplers and is returning the wrong value.

kos1
kos2

@Dunbaratu
Copy link
Member

It looks as if we'll just have to resurrect our old parts walk code and get it working again. The API from KSP for this that we switched to just doesn't work at all.

@Dunbaratu
Copy link
Member

Although... hang on.... you are clearly using a mod to display those stage values in the toolbar - that's not the stock way it looks in KSP. What is that mod? It might have publicly visible code that we can look at and figure out how the heck you're supposed to call the KSP API for it. The way it looks like you're supposed to doesn't work, as is clearly shown by these constant complaints about the stage values, and like everything in SQUAD's API, it's utterly undocumented how any of it is meant to be called. Seeing an example of how to call it that another mod is using might help.

@gregbean
Copy link
Author

gregbean commented May 9, 2015

It's TriggerAu's Alternate Resource Display.

On Fri, May 8, 2015 at 5:00 PM, Steven Mading notifications@github.com
wrote:

Although... hang on.... you are clearly using a mod to display those stage
values in the toolbar - that's not the stock way it looks in KSP. What is
that mod? It might have publicly visible code that we can look at and
figure out how the heck you're supposed to call the KSP API for it. The way
it looks like you're supposed to doesn't work, as is clearly shown by
these constant complaints about the stage values, and like everything in
SQUAD's API, it's utterly undocumented how any of it is meant to be called.
Seeing an example of how to call it that another mod is using might help.


Reply to this email directly or view it on GitHub
#981 (comment).

@Dunbaratu
Copy link
Member

Thanks. Might give it a look.

@Dunbaratu Dunbaratu added the bug Weird outcome is probably not what the mod programmer expected. label Dec 29, 2015
@Dunbaratu
Copy link
Member

Stage values have been a constant problem for ages. I'd like to see all the issues folded into one.

@hvacengi
Copy link
Member

hvacengi commented Jan 8, 2016

Fixed in #1082, #1233, and/or #1243

@hvacengi hvacengi closed this as completed Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Weird outcome is probably not what the mod programmer expected.
Projects
None yet
Development

No branches or pull requests

3 participants