Use RemoteTechFactory always when RemoteTech it is available #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erendrake
added a commit
that referenced
this pull request
Sep 28, 2015
Use RemoteTechFactory always when RemoteTech it is available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when deciding whether to use RemoteTechFactory kOSProcessor checks if the vessel has a flight computer. If it does not, then RT-related features are not enabled. As a result it is possible to construct a vessel without a flight computer (command pod + kos processor + battery), place it in orbit of duna and happily explore the archive even though the vessel has no antenna and no one on board.
This commit disables the flight computer check. I'm not 100% sure if it does not create problems somewhere else. Any testing/feedback would be appreciated.
This might have been the cause of #1088.