Fixes #1313 (waypoints). #1319
Merged
Fixes #1313 (waypoints). #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In testing this I also found a longstanding bug
that we never noticed before, in which it fails
to find a hit when the name does NOT use a greek
letter like "alpha" or "beta", but *does* contain
a space in the contract name.
i.e. like so:
Waypoint("apple") finds a waypoint called "apple"
correctly.
Waypoint("apple gamma") finds a waypoint called
"apple gamma" correctly, by stripping off the word
"gamma" and replacing it with the information that
this is waypoint index 2 of the set of waypoints
called "apple".
But Waypoint("apple lemon pear") fails. It has spaces but
NOT because it has a greek letter suffix. What the code
was doing was treating it like the last term was a
greek letter and stripping it whether it really was or not,
so it failed to find the waypoint because it looked for
it by the name "apple lemon".
This was fixed by this PR as well as the original problem
mentioned in the issue about the error message.
Dunbaratu
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing this I also found a longstanding bug
that we never noticed before, in which it fails
to find a hit when the name does NOT use a greek
letter like "alpha" or "beta", but does contain
a space in the contract name.
i.e. like so:
Waypoint("apple") finds a waypoint called "apple"
correctly.
Waypoint("apple gamma") finds a waypoint called
"apple gamma" correctly, by stripping off the word
"gamma" and replacing it with the information that
this is waypoint index 2 of the set of waypoints
called "apple".
But Waypoint("apple lemon pear") fails. It has spaces but
NOT because it has a greek letter suffix. What the code
was doing was treating it like the last term was a
greek letter and stripping it whether it really was or not,
so it failed to find the waypoint because it looked for
it by the name "apple lemon".
This was fixed by this PR as well as the original problem
mentioned in the issue about the error message.