Fixes #1328 esc in telnet #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was caused by the code presuming every time there was an ESC that there MUST be another character following it that it can read ahead on the next index. When there wasn't yet and the snippet of input chars just ended at the ESC, the attempt to go one more character forward threw an array bounds exception. This was never sent to the output_log, however because the telnet server runs in a separate thread and apparently the output_log only contains the main thread's output. When the telnet server thread died from the exception, the telnet client doesn't show anything about it, other than just freezing for several seconds and then eventually reporting a dropped connection.
Dunbaratu
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was caused by the code presuming every time there
was an ESC that there MUST be another character following it
that it can read ahead on the next index. When there wasn't
yet and the snippet of input chars just ended at the ESC, the
attempt to go one more character forward threw an array bounds
exception. This was never sent to the output_log, however
because the telnet server runs in a separate thread and
apparently the output_log only contains the main thread's output.
When the telnet server thread died from the exception, the telnet
client doesn't show anything about it, other than just freezing
for several seconds and then eventually reporting a dropped
connection.