Issue 1520 calculator structure #1523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vector.cs * Add Equals override method * Add == and != operators
CalculatorStructure.cs * Reduce dependence on Structure.TryOperation * Throw exceptions instead of TryOperation * Give the KOSName for types instead of C# name Add unit tests for scalar and structure.
CalculatorStructure.cs * Fixed the root of the recursion issue. Some types (specifically Vector) have implicit conversions that caused TryCoerceImplicit to continue to call over and over until running out of memory.
| // Check the equality of the quaternion components | ||
| if (d.rotation.x == rotation.x && | ||
| d.rotation.y == rotation.y && | ||
| d.rotation.z == rotation.z) |
There was a problem hiding this comment.
UnityEngine.Quaternion already has its own Equals() operator method defined. It might be a good idea to just defer to using that instead of re-implementing it (and I had a peek in ILSpy and it turns out what you're doing here isn't quite the same thing Unity is doing for Equals. You only compare the x, y, and z and Unity is comparing all 4 components (including the w).)
|
Removed milestone because we want more time to work this through and test it - just took the infnite recursion fix and nothing else for now. |
|
I'm adding the 1.0 milestone so that we don't miss it in that version |
…er null checking of course).
hvacengi
added
the
Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added .Equals and == operators to Direction and TimeStamp which didn't have them before. As I understand this is to help move away from TryOperation.