The changes to the KOS project to accompany new TinyPG. #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, this takes away the case-insensitive regex directive (``(?i)``) from the patterns, instead relying on the lowercasing techniquie used in the new TinyPG update we made.
|
I assigned this to @hvacengi to merge because it's really his work - I just made a PR for it because I had to do this anyway in order to test his other work. After you merge this, it might be a good idea to make a slack "everybody" announcement warning them of the information in the boldface text above. |
Dunbaratu
added
the
Not Ready
|
Okay, looking at the "files changed" list it's clear something wasn't right here. The kRISC file is missing from the list of changed files. That's why I marked it "not ready" until I investigate. |
Dunbaratu
removed
the
Not Ready
|
Okay, that's better. fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this is merged, then from then all all kOS developers who edit the
kRISC.tpgfile must compile it using our forked version of TinyPG at https://github.com/KSP-KOS/TinyPG, and NOT the stock version of TinyPG.Specifically, this takes away the case-insensitive regex directive (
(?i)) from the patterns, instead relying on the lowercasing technique used in the new TinyPG update we made.