Separate pitch, yaw and roll gimbal enabling/locking #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to tag issue #1587 here as it is the associated issue, but it won't fully fix it since that issue was focused heavily towards cooked steering. |
| AddSuffix("ROLL", new SetSuffix<BooleanValue>(() => gimbal.enableRoll, value => | ||
| { | ||
| gimbal.enableRoll = value; | ||
| }, "Does the Gimbal respond to roll controls?")); |
There was a problem hiding this comment.
The indentation above looks really wonky. The braces shouldn't be at the same level as the "A" in "AddSuffix" because they're a continuation of the AddSuffix call. They should be indented further in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the new features of 1.1 - ability to enable/disable pitch yaw and roll response of the gimbals separately.
Added corresponding suffixes to the Gimbal part module.