Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx handling sphinx and python versions #1826

Merged
merged 5 commits into from
Oct 29, 2016

Conversation

jacktose
Copy link
Contributor

This fixes both parts of #1825 by checking the versions of sphinx and python before doing version-specific things.

@Dunbaratu
Copy link
Member

Issue #1825 got closed without this PR being merged, which was supposed to have been the PR that would fix 1825. Can you elaborate?

@jacktose
Copy link
Contributor Author

jacktose commented Oct 28, 2016

Oh, huh. It got closed by PR #1834, but it doesn't look like any of those commits address the versioning issues. Maybe someone got confused because I submitted two different PRs at about the same time?

Has anyone attempted to replicate issue #1825 since that update?
If need be, I will when I have a minute.

@Dunbaratu
Copy link
Member

I am not in a position to test this because I'm not willing to upgrade to python 3 on account of other stuff I'm still using 2.x for that has similar forward-incompatibility issues.

@jacktose
Copy link
Contributor Author

Okay, updated to the current develop branch and tried again. I can replicate the issue.

@Dunbaratu
Copy link
Member

Dunbaratu commented Oct 29, 2016

I can replicate the issue.

meaing? The problem still exists in develop and we still need to apply this PR?
Again, the problem is I can't do much to test this beyond making sure it doesn't break older installs and thus doesn't make things worse. I guess that's the minimum criteria to make it acceptable to merge.

@jacktose
Copy link
Contributor Author

meaing? The problem still exists in develop and we still need to apply this PR?

Meaning exactly that! I commented on the issue to clarify.

I can't do much to test this beyond making sure it doesn't break older installs

I really hope you will, because I can't feasibly downgrade to Python 2.

@Dunbaratu Dunbaratu merged commit 4a3a733 into KSP-KOS:develop Oct 29, 2016
@Dunbaratu
Copy link
Member

Verified that it doesn't break my older sphinx/python setup, so I accepted and merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants