-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx handling sphinx and python versions #1826
Conversation
Issue #1825 got closed without this PR being merged, which was supposed to have been the PR that would fix 1825. Can you elaborate? |
Oh, huh. It got closed by PR #1834, but it doesn't look like any of those commits address the versioning issues. Maybe someone got confused because I submitted two different PRs at about the same time? Has anyone attempted to replicate issue #1825 since that update? |
I am not in a position to test this because I'm not willing to upgrade to python 3 on account of other stuff I'm still using 2.x for that has similar forward-incompatibility issues. |
Okay, updated to the current develop branch and tried again. I can replicate the issue. |
meaing? The problem still exists in develop and we still need to apply this PR? |
Meaning exactly that! I commented on the issue to clarify.
I really hope you will, because I can't feasibly downgrade to Python 2. |
Verified that it doesn't break my older sphinx/python setup, so I accepted and merged it. |
This fixes both parts of #1825 by checking the versions of sphinx and python before doing version-specific things.