Fix for issue #1849 #1851
Merged
Fix for issue #1849 #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvacengi
requested changes
Oct 21, 2016
| @@ -55,6 +55,17 @@ public class KACWrapper | |||
|
|
|||
| public static Boolean NeedUpgrade { get; private set; } | |||
|
|
|||
| internal static Type GetType(string name) | |||
There was a problem hiding this comment.
This doesn't really need to be internal, doing so in the IRWrapper makes a little sense because it is consistent with other wrappers, but it could simply be private for KACWrapper. Not a big enough deal to require a change alone, but I'm going to request another change anyways so I thought I might as well comment.
|
OK, I hadn't seen the error for the toolbar from kOS and never expected that kOS supports blizzy's toolbar. I updated the PR. |
hvacengi
approved these changes
Oct 21, 2016
hvacengi
added a commit
to hvacengi/KOS
that referenced
this pull request
Oct 25, 2016
In reviewing this PR (KSP-KOS#1851) I noticed that our source was old (old copyright dates) and didn't match the source at https://github.com/blizzy78/ksp_toolbar/blob/master/Wrapper/ToolbarWrapper.cs This updates the ToolbarWrapper.cs to match blizzy's current file. Most of it appears to be a formatting change, but I thought it would be good to staty current.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the errors I see, when ContractConfigurator is installed. #1849