Fixes #1971: Boolean meaning 0.00001 = true, 0.00000 = false #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I moved the code out of abstract class ScalarValue into the classes that override it, because I wanted to use a simple cast operator and to do that I need to know the type of Value at compile-time. I could have just used C#'s own knowledge of how you're meant to "convert" numbers to Booleans by doing Convert.ToBoolean(Value) in ScalarValue. It would have given the same result, but I think this way is a bit faster because it casts instead of using Convert methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1971
I moved the code out of abstract class ScalarValue
into the classes that override it, because I wanted
to use a simple cast operator and to do that I need
to know the type of Value at compile-time.
I could have just used C#'s own knowledge of how you're
meant to "convert" numbers to Booleans by doing
Convert.ToBoolean(Value) in ScalarValue. It would have
given the same result, but I think this way is a bit faster
because it casts instead of using Convert methods.