Fixes #1956 and changes font search order. #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When making the font dialog, I discovered that the font search list didn't actually work properly when the first font in the list was a bogus font name like "_not_picked_". Instead of trying the next font in the list, it was just rendering everything in Arial. There are some code changes to fix that problem too in here.
Dunbaratu
commented
May 7, 2017
| @@ -38,23 +38,23 @@ public class TermWindow : KOSManagedWindow , ITermWindow | |||
|
|
|||
| private bool collapseFastBeepsToOneBeep = false; // This is a setting we might want to fiddle with depending on opinion. | |||
|
|
|||
| private KeyBinding rememberThrottleCutoffKey; | |||
| private KeyBinding rememberThrottleFullKey; | |||
|
|
|||
There was a problem hiding this comment.
These two lines were unused fields causing a warning message. (They stopped being used once we stopped needing to have an ugly ad-hoc fix for locking out the 'Z' and 'X' keys.)
Deleting them was not related to this PR's purpose, but I removed them since I was in this file anyway and I noticed the warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1956
Note, because the only places I could find to download the C64 fonts from were sites with possibly invasive banner ads I didn't feel comfortable linking to in a URL, I decided to just mention the existence of the fonts out there, and let the user search for them, instead of including a direct URL.
When making the font dialog, I discovered
that the font search list didn't actually
work properly when the first font in the
list was a bogus font name like "not_picked".
Instead of trying the next font in the list, it was
just rendering everything in Arial.
There are some code changes to fix that problem too
in here.