Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop returning null if no next patch #2009

Merged
merged 1 commit into from
May 10, 2017
Merged

Stop returning null if no next patch #2009

merged 1 commit into from
May 10, 2017

Conversation

hvacengi
Copy link
Member

@hvacengi hvacengi commented May 9, 2017 •
edited
Loading

Fixes #1651
Fixes #1961

OrbitInfo.cs

  • If calling NEXTPATCH, don't return null if no next patch
  • Instead, throw an exception with advice to check HASNEXTPATCH
  • Small cleanup of usings

@hvacengi
Stop returning null if no next patch
dc685a9 
Fixes KSP-KOS#1651

OrbitInfo.cs
* If calling `NEXTPATCH`, don't return `null` if no next patch
* Instead, throw an exception with advice to check `HASNEXTPATCH`
* Small cleanup of usings
@hvacengi hvacengi requested a review from Dunbaratu May 9, 2017 03:17
@hvacengi hvacengi added the Error Messages Feedback to the user explaining an error doesn't explain it properly. label May 9, 2017
@hvacengi hvacengi added this to the v1.1.0 milestone May 9, 2017
@Dunbaratu Dunbaratu merged commit dc685a9 into KSP-KOS:develop May 10, 2017
@hvacengi hvacengi deleted the issue-1651-orbit_nextpatch_null branch May 13, 2017 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dunbaratu Dunbaratu Awaiting requested review from Dunbaratu

Assignees
No one assigned
Labels
Error Messages Feedback to the user explaining an error doesn't explain it properly.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hvacengi @Dunbaratu