Fixes #1860 - progress bar terminal resize #2076
Conversation
To test: - Be sure RemoteTech is installed. - Start new sandbox game. Choose RemoteTechConnectivityManager. - Use Alt-F12 'set orbit' cheat to put a comsat into Kerbin orbit that can act as a relay to Duna. - Use Alt-F12 'set orbit' cheat to put a kOS-capable probe around Duna that relays through the satellite you made above. - Keep trying ``print "hello".`` in the probe's kOS Terminal, after resizing the terminal to different amounts. Notice it will react to changes to the terminal made during the progres bar's wait time too, re-drawing the bar to fit the new size at the same ratio of completion it had before.
| { | ||
| progressBarSubBuffer = new SubBuffer(); | ||
| RemoveResizeNotifier(CreateProgressBarSubBuffer); | ||
| } |
There was a problem hiding this comment.
I just realized this won't work. The destructor never gets called until after you orphan this instance. This instance can't orphan until after you call RemoveResizeNotifier(), so this can never actually get called. This has to be moved elsewhere in the logic, not in the destructor.
There was a problem hiding this comment.
Addendum: Okay, actually it probably did work all along. I put it back, with the explanatory comment about why it probably was fine all along. But even so, I still added the hook removal to SharedObjects's Destroy work just to be explicit about it. Now there's two spots that can both catch this and do the job.
Dunbaratu
added
the
Not Ready
This is a better place to remove the hooks, because the destructor (where they were) cannot fire off while the hook itself is preventing orphaning. I left the old location in place as well, because I think it can still fire too and it works as a fallback if we don't always remember to remove those hooks.
One of my files wasn't changed on disk yet. Now it is.
| { | ||
| progressBarSubBuffer = new SubBuffer(); | ||
| RemoveResizeNotifier(CreateProgressBarSubBuffer); | ||
| } |
There was a problem hiding this comment.
Addendum: Okay, actually it probably did work all along. I put it back, with the explanatory comment about why it probably was fine all along. But even so, I still added the hook removal to SharedObjects's Destroy work just to be explicit about it. Now there's two spots that can both catch this and do the job.
Dunbaratu
removed
the
Not Ready
Fixes #1860
To test:
that can act as a relay to Duna.
relays through the satellite you made above.
print "hello".in the probe's kOS Terminal,after resizing the terminal to different amounts. Notice it will
react to changes to the terminal made during the progres bar's
wait time too, re-drawing the bar to fit the new size at the same
ratio of completion it had before.