Fixes #2085 path equality overrides

src/kOS.Safe/Persistence/GlobalPath.cs

@@ -192,19 +192,34 @@ public override int GetHashCode()
 
         public override bool Equals(object other)
         {
+            Console.WriteLine("eraseme: GlobalPath.Equals(): does " + this.ToString() + " == " + other.ToString() + " ?");
             GlobalPath otherPath = other as GlobalPath;
 
-            if (otherPath == null)
+            if (ReferenceEquals(otherPath, null)) // ReferenceEquals prevents infinite recursion with overloaded == operator.
             {
                 return false;
             }
+            bool result =  VolumeId.Equals(otherPath.VolumeId) && Segments.SequenceEqual(otherPath.Segments);
+            Console.WriteLine("eraseme: Result = " + result);
+            return result;
+        }
+
+        public static bool operator ==(GlobalPath left, GlobalPath right)
+        {
+            if (ReferenceEquals(left,null) || ReferenceEquals(right,null)) // ReferenceEquals prevents infinite recursion with overloaded == operator.
+                return ReferenceEquals(left, null) && ReferenceEquals(right, null); // ReferenceEquals prevents infinite recursion with overloaded == operator.
+            return left.Equals(right);
+        }
 
-            return VolumeId.Equals(otherPath.VolumeId) && Segments.SequenceEqual(otherPath.Segments);
+        public static bool operator !=(GlobalPath left, GlobalPath right)
+        {
+            return !(left == right);
         }
 
         public override string ToString()
         {
             return VolumeId + ":" + base.ToString();
         }
+
     }
 }

src/kOS.Safe/Persistence/PathValue.cs

@@ -94,6 +94,39 @@ public override string ToString()
         {
             return Path.ToString();
         }
+
+        public override bool Equals(object other)
+        {
+            Console.WriteLine("eraseme: PathValue.Equals(): this = " + this.ToString() + ", other = " + other.ToString());
+            PathValue pVal = other as PathValue;
+            if (!ReferenceEquals(pVal,null)) // ReferenceEquals prevents infinite recursion with overloaded == operator.
+                return Path == pVal.Path;
+            GlobalPath gVal = other as GlobalPath;
+            if (!ReferenceEquals(gVal,null)) // ReferenceEquals prevents infinite recursion with overloaded == operator.
+                return Path == gVal;
+
+            // fallback:
+            return base.Equals(other);
+        }
+
+        public override int GetHashCode()
+        {
+            if (!ReferenceEquals(Path,null)) // ReferenceEquals prevents infinite recursion with overloaded == operator.
+                return Path.GetHashCode();
+            return base.GetHashCode();
+        }
+
+        public static bool operator ==(PathValue left, PathValue right)
+        {
+            if (ReferenceEquals(left,null) || ReferenceEquals(right,null)) // ReferenceEquals prevents infinite recursion with overloaded == operator.
+                return ReferenceEquals(left, null) && ReferenceEquals(right, null); // ReferenceEquals prevents infinite recursion with overloaded == operator.
+            return left.Equals(right);
+        }
+        public static bool operator !=(PathValue left, PathValue right)
+        {
+            return !(left == right);
+        }
+
     }
 }
 

src/kOS.Safe/Persistence/VolumePath.cs

@@ -219,14 +219,27 @@ public override bool Equals(object other)
         {
             VolumePath otherPath = other as VolumePath;
 
-            if (otherPath == null)
+            if (ReferenceEquals(otherPath,null)) // ReferenceEquals prevents infinite recursion with overloaded == operator.
             {
                 return false;
             }
 
             return Segments.SequenceEqual(otherPath.Segments);
         }
 
+        public static bool operator ==(VolumePath left, VolumePath right)
+        {
+            if (ReferenceEquals(left,null) || ReferenceEquals(right,null)) // ReferenceEquals prevents infinite recursion with overloaded == operator.
+                return ReferenceEquals(left, null) && ReferenceEquals(right, null); // ReferenceEquals prevents infinite recursion with overloaded == operator.
+            return left.Equals(right);
+        }
+
+        public static bool operator !=(VolumePath left, VolumePath right)
+        {
+            return !(left == right);
+        }
+
+
         public override string ToString()
         {
             return "/" + String.Join("/", Segments.ToArray());