Issue 2127 RemoteTech local control #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemoteTechConnectivityManager.cs * Check both HasAnyConnection and HasLocalControl when checking for control connection * Implement logic out of RemoteTechUtility for GetDelayToControl
RemoteTechUtility.cs, RemoteTechHook.cs, RemoteTechInterpreter.cs * Delete files no longer in use kOS.csproj * Remove reference to RemoteTechUtility.cs
|
reminder to self: also check on ksp 1.2.2 with older RT. |
…127-RT_local_control
RemoteTechConnectivityManager.cs * Update manager to return true for HasConnectionToControl if the vessel has local control but no RT part installed * Update event subscription to fallback to stock events if RT isn't available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2127
Fixes the RemoteTechConnectivityManager to check HasLocalControl when evaluating HasConnectionToControl. Also removes a few old files and a utility class.