[Fixes #2345] Quick fix for handling files with BOMs in them. #2353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2345
I've got the idea here. I've run some tests with differently encoded files (clean, UTF-8, UTF-16 LE, and UTF-16 BE) and everything seems to work correctly.
The linked page and the comments in the code should be self-explanatory.
I don't know how solid this is, but I think it simple and stable enough to be easily merged into the main develop branch.
Also, this is my first PR... :-)